Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds NSURL parsing #10

Merged
merged 1 commit into from Apr 14, 2016
Merged

Adds NSURL parsing #10

merged 1 commit into from Apr 14, 2016

Conversation

s4cha
Copy link
Member

@s4cha s4cha commented Apr 14, 2016

@maxkonovalov since you're a regular contributor I figured I'd make Pull requests as well so that we can discuss things together.

This transforms

if let link = json["link"] as? String, url = NSURL(string:link)  {
    profile.link = link
}

into

link <-- json["link"]

What do you think ?

@maxkonovalov
Copy link
Member

Hey @s4cha, this is great, for some reason I thought that Arrow would support NSURL parsing already 😀 so this is a really welcome addition. 👏

BTW, I think you can assign the PRs you would like to review to me so that I merge and close them.

@s4cha s4cha assigned s4cha and unassigned s4cha Apr 14, 2016
@s4cha
Copy link
Member Author

s4cha commented Apr 14, 2016

@maxkonovalov nice!
Unfortunately we can only assign contributors to PRs :(
Let's keep it this way for now then ;)

@s4cha s4cha merged commit 1e2a397 into master Apr 14, 2016
@s4cha s4cha deleted the nsurl branch April 17, 2016 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants