Documentation lacks examples using Codable structs

[djrobby]

I would really like to use your library in my current project but I'm having a real hard time getting POST, PUT and DELETE requests to work with Codable structs. Your documentation, including tests, only showcase rather simple examples that use strings as params. It would be nice if you could include addtional examples utilizing Codable structs. Thanks!

[s4cha]

Hi @djrobby, indeed the examples in the tests are quite succinct. For an example in a real Appstore App you could check out the code of this fully open-source App :https://github.com/EuroScorer/EuroScorer-iOS
especially https://github.com/EuroScorer/EuroScorer-iOS/blob/master/EuroScorer/Firebase/FirebaseModels.swift and https://github.com/EuroScorer/EuroScorer-iOS/blob/master/EuroScorer/Firebase/FirebaseImplementation.swift

The particularity in this example is that Codable Models have been hidden behind a protocol for cleanness sake but you don't have to go to this level of abstraction if you don't want to. This technique enables us to hide away Firebase and the JSON api from the rest of the app.

// Your Model (Simplified)
struct FirebaseSong: Song, Decodable {
    let title: String

    enum CodingKeys: String, CodingKey {
        case title = "title"
    }
}

// Tell Netwoking that its JSONDecodable (its empty since implementation is provided by default for Codables)
extension FirebaseSong: NetworkingJSONDecodable {}

// Perform your call
 func fetchSongs() -> AnyPublisher<[Song], Error> {
    get("/songs").map { (firebaseSongs: [FirebaseSong]) -> [Song] in
        firebaseSongs.map { $0 as Song }
    }.eraseToAnyPublisher()
}

Let me know if that helps :)

[s4cha]

@djrobby Did that help?

[djrobby]

Yes, all set! Sorry, I forgot to mark the issue closed. done!