Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift package Tests #129

Merged
merged 2 commits into from Nov 13, 2019
Merged

Swift package Tests #129

merged 2 commits into from Nov 13, 2019

Conversation

lukas-ruzicka
Copy link
Contributor

This is needed to be able to pass Swift package tests since the package can be used for multiple platforms. If you're not using these tests, it is needed for every other Swift package which implements yours.

@lukas-ruzicka
Copy link
Contributor Author

Already tested, tests now works 😎

@s4cha
Copy link
Member

s4cha commented Nov 6, 2019

@lukysnupy Thanks a ton for taking the time to issue a PR. This is very appreciated 🙏 . I am not very familiar with SPM yet, could you point to a documentation referring to #if canImport() ?

@lukas-ruzicka
Copy link
Contributor Author

Here you can find it in the Make Your Swift Package Cross-Platform Compatible section ✌🏼

@s4cha
Copy link
Member

s4cha commented Nov 13, 2019

@lukysnupy Perfect 👌

@s4cha
Copy link
Member

s4cha commented Nov 13, 2019

@lukysnupy By the way, could you tell me how I can run those "tests" you are talking about ?

@s4cha s4cha merged commit f2801f8 into freshOS:master Nov 13, 2019
@lukas-ruzicka
Copy link
Contributor Author

Thanks for merging it 💪🏼 We're using fastlane method spm during our CI process: https://docs.fastlane.tools/actions/spm/

s4cha added a commit that referenced this pull request Jun 29, 2020
s4cha added a commit that referenced this pull request Jun 29, 2020
s4cha added a commit that referenced this pull request Jun 29, 2020
s4cha added a commit that referenced this pull request Jun 29, 2020
s4cha added a commit that referenced this pull request Jun 29, 2020
s4cha added a commit that referenced this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants