Deprecated: strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated in /usr/local/www/freshports/classes/port-display.php on line 941

[grahamperrin]

Deprecated: strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated in /usr/local/www/freshports/classes/port-display.php on line 941

Appears:

• twice at the head of https://www.freshports.org/ports-expiration-date.php (page one of two)
• once at the head of https://www.freshports.org/ports-expiration-date.php?page=2
• eight times at the head of https://www.freshports.org/ports-deleted.php (page one of 224)
• five times at the head of https://www.freshports.org/ports-deleted.php?page=224

[dlangille]

Confirmed present on dev. Then fixed with this patch. Tests fine on dev now.

[18:52 dev-nginx01 dan ~/www] % git diff classes/port-display.php
diff --git a/classes/port-display.php b/classes/port-display.php
index 13d18c6c..11d72143 100644
--- a/classes/port-display.php
+++ b/classes/port-display.php
@@ -938,7 +938,7 @@ class port_display {
                        $HTML .=  ' <span class="tooltip">';
                        if (empty($port->quarterly_revision)) {
                                $HTML .= 'Port not present on quarterly';
-                               if (date("Y-m-d", strtotime($port->date_added)) > FirstDateOfCurrentQuarter()) {
+                               if (IsSet($port->date_added) && date("Y-m-d", strtotime($port->date_added)) > FirstDateOfCurrentQuarter()) {
                                        $ToolTipText = 'This is expected as this port was created during this quarter.';
                                } else {
                                        $ToolTipText = 'This missing version is most likely a FreshPorts error.';

[grahamperrin]

Thanks for the quick fix.

[dlangille]

Now fixed on test, stage, and prod.