Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--ref=foo should work with remote branches #148

Open
jasoncodes opened this issue May 6, 2017 · 1 comment
Open

--ref=foo should work with remote branches #148

jasoncodes opened this issue May 6, 2017 · 1 comment

Comments

@jasoncodes
Copy link
Member

We currently call git show $REF:$PATH which does not match remote branches. It only works with commit refs and local branches names. When the branch has not been check

Do we need to failover to git show origin/$REF:$PATH if git show $REF:$PATH fails? Seems like the easiest option.

A missing ref currently outputs the following:

fatal: Not a valid object name $REF
Error: Could not find "$PATH" source file.
/home/user/.freshrc:1: fresh $REPO $PATH --ref=$REF

The first line is from the git show call. If we match origin/$REF after failing $REF, we should not output the fatal: Not a valid object name error from the first call. We should probably output both errors if both calls fail.

@kuba-gaj
Copy link

+1, I recently had issue with remote branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants