[dev] Add prometheus metrics #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't look like a breaking change. Would it make sense to include it in v2? |
|
Yes. One moment. |
|
👌 |
freyacodes
pushed a commit
to freyacoded/repo-test
that referenced
this pull request
Oct 11, 2022
* Add prometheus metrics for logs and basic jvm stats * Adjust for Java 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic metrics for logs and the JVM.
The metrics beans are fully conditional, so not opting in to metrics should have no impact™
No security has been added. Security is achieved by not exposing the host to public networks in the first place, or using a reverse proxy (and any security measures of the user's choice and the chosen reverse proxies' capability).