Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release must use semver #53

Closed
Freyskeyd opened this issue Dec 1, 2017 · 3 comments
Closed

Release must use semver #53

Freyskeyd opened this issue Dec 1, 2017 · 3 comments
Labels
bug

Comments

@Freyskeyd
Copy link
Owner

Hello,

Our project must use semver for release. The v1.0 isn't semver. It should be v1.0.0
@Freyskeyd Freyskeyd added the bug label Dec 1, 2017
@shannonlal
Copy link
Collaborator

Ok. I will fix that now

@shannonlal
Copy link
Collaborator

Update to this. The package and npm naming convention are okay it just the release name in git. I will update a fix for this and merge it in.

@shannonlal shannonlal mentioned this issue Dec 5, 2017
Merged
@shannonlal
Copy link
Collaborator

Fixed the correct release name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Freyskeyd @shannonlal