Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer Sizing Issue with Footer Items #61

Open
mrhaubrich opened this issue Dec 7, 2023 · 0 comments
Open

Footer Sizing Issue with Footer Items #61

mrhaubrich opened this issue Dec 7, 2023 · 0 comments

Comments

@mrhaubrich
Copy link

Is your feature request related to a problem? Please describe.
I've found the library and it is awesome, but when I added footerItems, the footerSeparator was in a bad position, in the middle of the sidebar, instead of the bottom, as expected.

Describe the solution you'd like
I've created a fork and added a enum "FooterFitType" that can be "fit" or "expand". And send it as a parameter to the SidebarX class, setting the default value as "expanded" so the new update won't break existing projects.

Describe alternatives you've considered
I've considered setting as default to always fit the items, instead of expanding, but maybe someone needs the expanded approach. Later, I've considered using a boolean to tell if it fits or not, but found more readable being a enum.

Additional context
Current approach:
Code:
image

Sidebar:
image

My solution:
Code:
image

Sidebar:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant