Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] spli the client from cli (take 2.1) #50

Merged
merged 1 commit into from
Dec 16, 2016
Merged

[WIP] spli the client from cli (take 2.1) #50

merged 1 commit into from
Dec 16, 2016

Conversation

Fak3
Copy link
Contributor

@Fak3 Fak3 commented Dec 16, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 85.422% when pulling 445ce86 on Fak3:f43_2 into 2c96971 on frictionlessdata:master.

@rufuspollock
Copy link
Contributor

General comment: Please give more descriptive PR items e.g. this could have been:

Client validate tests.

In terms of commit message:

[client][m]: add tests for client.validate() [and anything else you did]

@rufuspollock
Copy link
Contributor

Overall looks very good. Merging now.

@rufuspollock rufuspollock merged commit b86556b into openknowledge-archive:master Dec 16, 2016
@Fak3
Copy link
Contributor Author

Fak3 commented Dec 19, 2016

In the commit message - what does the items inside brackets mean?

@rufuspollock
Copy link
Contributor

@Fak3 did you read @anuveyatsu gist about this? If not, ask him.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fak3 @coveralls @rufuspollock