Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port main.py to new client, fix tests. #59

Merged
merged 15 commits into from
Dec 21, 2016
Merged

Port main.py to new client, fix tests. #59

merged 15 commits into from
Dec 21, 2016

Conversation

Fak3
Copy link
Contributor

@Fak3 Fak3 commented Dec 20, 2016 •
edited

FIxes #55

@Fak3
Add cli test for invalid dp schema
e5e855b 
Addresses openknowledge-archive#55
@Fak3
Fix test_validate_nondp_dir.py
4998883 
Addresses openknowledge-archive#55
@Fak3
Fix test_configure_success.py
9bd2bc3 
Addresses openknowledge-archive#55
@Fak3
Fix test_publish_success.py
f1f9659 
Addresses openknowledge-archive#55
@Fak3
Fix test_publish_invalid.py
76ebdd7 
Addreses openknowledge-archive#55
@Fak3
Split out and fix test_publish_missing_credentials.py
032bb7c 
Addresses openknowledge-archive#55
@Fak3
Split out and fix test_publish_authserver_error.py
2a47f0c 
Addresses openknowledge-archive#55
@Fak3
Fix tests/test_readme.py
a72dcaf 
Addresses openknowledge-archive#55
@Fak3
Fix tests/test_delete_purge_success.py
e863ea4
@Fak3
Fix tests/test_configure_success.py
b2c525f
@Fak3
Fix tests mock
d55dc23
@Fak3
Fix py3 tests
b7fd277
@Fak3
Port main.py to new Client
a979912 
Addresses openknowledge-archive#55
@coveralls
Copy link

coveralls commented Dec 20, 2016 •
edited

Coverage Status

Coverage decreased (-16.9%) to 69.293% when pulling a979912 on Fak3:f55_cli into 6b5dc87 on frictionlessdata:master.

@coveralls
Copy link

coveralls commented Dec 20, 2016 •
edited

Coverage Status

Coverage decreased (-16.9%) to 69.293% when pulling a979912 on Fak3:f55_cli into 6b5dc87 on frictionlessdata:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+11.4%) to 97.561% when pulling 560c57b on Fak3:f55_cli into 6b5dc87 on frictionlessdata:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+11.4%) to 97.561% when pulling 560c57b on Fak3:f55_cli into 6b5dc87 on frictionlessdata:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+11.4%) to 97.561% when pulling 560c57b on Fak3:f55_cli into 6b5dc87 on frictionlessdata:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+11.4%) to 97.561% when pulling 560c57b on Fak3:f55_cli into 6b5dc87 on frictionlessdata:master.

zelima
zelima reviewed Dec 20, 2016
View reviewed changes
tests/test_validate_nondp_dir.py
@@ -23,7 +23,7 @@ def test_validate_empty_dir(self):
# WHEN `dpm validate` is invoked
result = self.invoke(cli, ['validate'])

# THEN exit code should be 1
# THEN 'datapackage.json not found' should be printed to stdout
self.assertRegexpMatches(result.output, 'Did not find datapackage.json')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the comment should be # THEN 'Did not find datapackage.json' ... probably

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed

@coveralls
Copy link

coveralls commented Dec 20, 2016 •
edited

Coverage Status

Coverage increased (+11.4%) to 97.561% when pulling a8dbd91 on Fak3:f55_cli into 6b5dc87 on frictionlessdata:master.

zelima
zelima reviewed Dec 21, 2016
View reviewed changes
tests/test_publish_authserver_error.py
result = self.invoke(cli, ['publish'])

# THEN 'server did not return resource put url' should be printed to stdout
self.assertRegexpMatches(result.output, 'server did not provide upload authorization for path:')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but again, comment and actual output mismatch

@zelima
Copy link
Contributor

zelima commented Dec 21, 2016 •
edited

Look good to me. merging

@zelima zelima merged commit 3b2c046 into openknowledge-archive:master Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zelima zelima zelima left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fak3 @coveralls @zelima