Merge pull request #35 from kittdotech/test-end-to-end

[publish][s #34]: Finalization request in POST
openknowledge-archive · Nov 17, 2016 · 81ca097 · 81ca097
2 parents 227d6cc + 634fed3
commit 81ca097
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/dpm/client/do_publish.py b/dpm/client/do_publish.py
@@ -112,7 +112,7 @@ def publish(ctx, username, password, server, debug):
                                     'Content-Length': '%d' % filestream.len})
 
     echo('Finalizing ... ', nl=False)
-    response = request('GET',
+    response = request('POST',
                        '%s/api/package/%s/%s/finalize' % (
                            server, username, dp.descriptor['name']),
                        headers={'Authorization': 'Bearer %s' % token})

diff --git a/tests/test_publish_success.py b/tests/test_publish_success.py
@@ -68,7 +68,7 @@ def test_publish_success(self):
             status=200)
         # AND registry server successfully finalizes upload
         responses.add(
-            responses.GET, 'https://example.com/api/package/user/some-datapackage/finalize',
+            responses.POST, 'https://example.com/api/package/user/some-datapackage/finalize',
             json={'message': 'OK'},
             status=200)
 
@@ -100,7 +100,7 @@ def test_publish_success(self):
                 # PUT README to S3
                 ('PUT', 'https://s3.fake/put_here', ''),
                 # GET finalize upload
-                ('GET', 'https://example.com/api/package/user/some-datapackage/finalize', '')])
+                ('POST', 'https://example.com/api/package/user/some-datapackage/finalize', '')])
         # AND PUT request should contain serialized datapackage metadata
         self.assertEqual(
             responses.calls[1].request.body.decode(), self.valid_dp.to_json())

diff --git a/tests/test_readme.py b/tests/test_readme.py
@@ -114,12 +114,12 @@ def test_readme_sucess_for_multiple_readme(self):
             status=200)
         # AND registry server successfully finalizes upload
         responses.add(
-            responses.GET, 'https://example.com/api/package/user/some-datapackage/finalize',
+            responses.POST, 'https://example.com/api/package/user/some-datapackage/finalize',
             json={'message': 'OK'},
             status=200)
         # WHEN `dpm publish` is invoked
         result = self.invoke(cli, ['publish', '--publisher', 'testpub'])
-
+        self.assertRegexpMatches(result.output, 'publish ok')
         # Checking README uploading first match
         self.assertNotIn('Publishing Package without README', result.output)
         self.assertIn('Uploading README.txt', result.output)