Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this library alive? #334

Closed
GMaiolo opened this issue Feb 21, 2020 · 22 comments
Closed

Is this library alive? #334

GMaiolo opened this issue Feb 21, 2020 · 22 comments

Comments

@GMaiolo
Copy link

GMaiolo commented Feb 21, 2020

There have been a lot of changes in NextJS router and other core functionalities and it seems that this library hasn't been updated for more than 2 years now

@irhamputra
Copy link

@GMaiolo i think so but luckily this lib is still compatible with next v9. I've been using this start from last week it is still working right now. idk after next.js team release new major version

@joaogarin
Copy link

Not completely #329

@ost-ing
Copy link

ost-ing commented Mar 23, 2020

Considering the number of people that probably use this library, the maintainer/owner of next-routes should update the README informing people that its not longer being actively maintained.

I will be removing it from my project now.

@rfm-bot
Copy link

rfm-bot commented Apr 28, 2020

🚧 Is this repo looking for support?
Hello, we created this issue becuase the user @sospedra told us you are calling for maintainers.
✅ If you're looking for collaborators no action is required.
👮🏻‍♂️ If this repo is well-supported please put a comment here sospedra/rfm#52 and we'll close it immediately.
Sorry for any inconvinience. We understand this message can feel spammy but we really think is good to double-check first with the current owners :)

@msreekm
Copy link

msreekm commented Jun 18, 2020

Assuming that this library is kind of abandoned at this point, Is there an alternate library for routing with next.js, if someone do not want to use file based routing ?

@Judahmeek
Copy link

Anyone got a guide for removing this library?

I took over a project using this library & my attempt to remove it resulted in Cannot GET errors from all routes. You'd think I had deleted the pages directory or something.

@joaogarin
Copy link

joaogarin commented Jun 30, 2020

Unfortunately the problem is that next doesnt have certain features in order to really remove the library. Custom routes in nextjs will help (and maybe enough for certain use cases) but there is no fully dynamic route solution like this library provides (if you have for example routes coming from a CMS).

@kenberkeley
Copy link

#244 (comment)

@GMaiolo
Copy link
Author

GMaiolo commented Jul 8, 2020

@kenberkeley still radio silence though, and no updates to the library since June 29, 2018

Ping @Timer!

@msreekm
Copy link

msreekm commented Jul 16, 2020

From what I have seen so far , the next,js project priorities are set for based on what is required for vercel platform and not necessarily based on the needs of the community. in this case ,this may be a low priority for vercel.

@andreasblueher
Copy link

The last commit to github! by the owner was in may 2019. It seems he has not abandoned this library, but rather github in general. What about some contributers here? Someone who would take over? is that even possible?

@ost-ing
Copy link

ost-ing commented Nov 28, 2020 via email

@andreasblueher
Copy link

Thanks for pointing that out @ostenning

@msreekm
Copy link

msreekm commented Nov 29, 2020

I have already started migrating to next routing.

@meabed
Copy link

meabed commented May 23, 2021

I have just forked the repo and updated it to latest versions with the correct types, all test are passing 🟢 👍
https://github.com/meabed/next-routes-extended
https://www.npmjs.com/package/next-routes-extended

@albertvolkman
Copy link

@meabed

I think you have an issue here- https://github.com/meabed/next-routes-extended/blob/master/package.json#L39

When trying to install your package, I get an error Invalid tag name "=>15.4.2": Tags may not have any characters that encodeURIComponent encodes.

@meabed
Copy link

meabed commented May 24, 2021

@meabed

I think you have an issue here- https://github.com/meabed/next-routes-extended/blob/master/package.json#L39

When trying to install your package, I get an error Invalid tag name "=>15.4.2": Tags may not have any characters that encodeURIComponent encodes.

Oops 🙊 you are right, I'll fix this right away and release it.
I'm also planning to add more examples, we are using this routes extensively in a lot of different use cases and I think it will be helpful to share them as well.

@meabed
Copy link

meabed commented May 24, 2021

@albertvolkman is fixed and pushed!
I am adding an example folder with different use-cases later today!

@cvolant
Copy link

cvolant commented Jun 9, 2021

@meabed thank you to take over.
Do you plan to make it compatible with Next built-in i18n routing?

@meabed
Copy link

meabed commented Jun 9, 2021

@meabed thank you to take over.
Do you plan to make it compatible with Next built-in i18n routing?

Yes - absolutely - I am adding and example code-sanebox with all use cases, i use it already multi-lingual and works well!
I will share different complete working solution with codesanbox, if you have something specific let me know.
Thank you!

@cvolant
Copy link

cvolant commented Jun 11, 2021

Great!
And do you think it will support getStaticProps? Like:

MyPage.getStaticProps(({ locale }) => {
  [...]
})

@GMaiolo
Copy link
Author

GMaiolo commented Jun 11, 2021

Could we move the convo about the fork to the fork? Seems proper

@fridays fridays closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests