Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup with detailed information #33

Closed
MXEH opened this issue Sep 28, 2021 · 9 comments
Closed

Popup with detailed information #33

MXEH opened this issue Sep 28, 2021 · 9 comments
Labels
bug Something isn't working

Comments

@MXEH
Copy link

MXEH commented Sep 28, 2021

There's also a problem the popup with detailed information on all individual rules. It displays correctly only in the Vertical View layout. In others, depending on the height of the message window, the information doesn't appear completely and the scroll bar doesn't appear.

Vertical View
obraz

Wide View or Classic View
obraz

Thunderbird Version: 78.14.0 (OS: Windows 7; )
Spam Score add-on Version: 1.2.0, 1.3.1

@MXEH MXEH added the bug Something isn't working label Sep 28, 2021
@MXEH

This comment has been minimized.

@friedPotat0
Copy link
Owner

This seems to me like a Thunderbird 78 bug. I've tested the vertical layout on the latest version of Thunderbird (91.1.2) and the popup displays a scrollbar when the rows don't fit on the screen.

@MXEH
Copy link
Author

MXEH commented Oct 4, 2021

In this example, for Vertical View, everything is fine. It's a full view and everything is fine here. The same preview for Wide View or Classic View is different and sometimes the scroll bar doesn't show or shows incomplete without the bottom arrow. You cannot see all the data then. It all depends on the height of the e-mail list window and the preview of the e-mail content. Switch Thunderbird to Wide View or Classic View, and test by changing the height of the email content view window.

obraz

@friedPotat0
Copy link
Owner

Sorry, I meant the wide view layout in my last comment not the vertical view. I've done some more tests with different screen sizes and was now able to reproduce the problem even on the latest Thunderbird 91.

I don't think it is a problem of the add-on rather than a general problem with popup windows in Thunderbird not adjusting to the screen boundaries when the popop is too large. I will check if there is any way to detect the space left to limit the height of the popup.

@MXEH
Copy link
Author

MXEH commented Oct 4, 2021

I will also install the latest version of Thunderbird 91 for testing, because maybe this problem doesn't occur in the new version. :)

@MXEH
Copy link
Author

MXEH commented Oct 4, 2021

I tested the popup on Thunderbird 91.1.2 and it's ok. The problem only occurs in the older version 78.x. :) In 78.x the popup started with the Spam Scores button, but in 91.x it isn't.

obraz

@friedPotat0
Copy link
Owner

This is true in most cases. Nevertheless, I was able to reproduce the issue in Thunderbird 91 as you can see in the following screenshot. It still fails to adjust the size of the popup when the message pane and the list view is divided just above the middle of the screen. In this case the popup is displayed behind the taskbar.

image

@MXEH
Copy link
Author

MXEH commented Oct 5, 2021

I tested today and I also had a case where the popup isn't complete and there's no scroll bar.

obraz

@friedPotat0
Copy link
Owner

The problem should be fixed in the next update , which will be released this week. Please reopen this issue if the problem still persists after the update as I am currently not able to test the implemented workaround on older versions of Thunderbird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants