Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

What is the need for Application class in the hide function #21

Closed
ghost opened this issue Dec 8, 2015 · 4 comments
Closed

What is the need for Application class in the hide function #21

ghost opened this issue Dec 8, 2015 · 4 comments

Comments

@ghost
Copy link

ghost commented Dec 8, 2015

TinyDancer.hide(Application) takes an application instance but calls TinyDancerBuilder.hide(Context), this reduces the flexibility as you need to put an extra method in the application class.

@ghost
Copy link
Author

ghost commented Dec 8, 2015

Although you can do ((Application) context.getApplicationContext()) but still passing context should suffice

@digitalbuddha
Copy link
Collaborator

good suggestion. thanks for using. Let me know if anything else is out of place.

@ghost
Copy link
Author

ghost commented Dec 8, 2015

Thanks will do, can you do a release on this ASAP ☺
On 08-Dec-2015 9:00 am, "Mike Nakhimovich" notifications@github.com wrote:

good suggestion. thanks for using. Let me know if anything else is out of
place.


Reply to this email directly or view it on GitHub
https://github.com/brianPlummer/TinyDancer/issues/21#issuecomment-162748653
.

@digitalbuddha
Copy link
Collaborator

Release .8 has been submitted to maven, readme will be updated when it is actually live.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant