Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use collections.ChainMap instead of homegrown Events type #56

Open
goodboy opened this issue Jan 1, 2018 · 0 comments
Open

Use collections.ChainMap instead of homegrown Events type #56

goodboy opened this issue Jan 1, 2018 · 0 comments

Comments

@goodboy
Copy link
Member

goodboy commented Jan 1, 2018

Our homegrown switchio.models.Events data structure for storing event streams looks a lot like the stdlib's collections.ChainMap. The only major difference seems to be that Events supports slicing which should be the same as slicing ChainMap.maps?

I propose seeing if we can just move to ChainMap (at least a subtype of it) since it accomplishes an additional goal I had to make Events a subtype of MutableMapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant