Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchBehavior unable to use non default filters collection. #117

Closed
ADmad opened this issue Sep 7, 2016 · 2 comments
Closed

SearchBehavior unable to use non default filters collection. #117

ADmad opened this issue Sep 7, 2016 · 2 comments
Milestone

Comments

@ADmad
Copy link
Member

ADmad commented Sep 7, 2016

The SearchManager has the ability to maintain multiple filter collections. For e.g. you can have separate collections for backend and frontend. But when using the search finder there's no way to tell it to which collection to use. It always uses the "default" collection.

The fix seems easy enough. Just allow passing a collection key to finder options and update the behavior to use SearchBehavior::getFilters() passing in the collection name instead of calling SearchBehavior::all() which always returns the default collection.

@ADmad ADmad added this to the 2.x milestone Sep 7, 2016
@flangofas
Copy link
Contributor

I will provide a fix for this one.

@ADmad
Copy link
Member Author

ADmad commented Sep 8, 2016

@flangofas Great! Don't forget tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants