Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide empty fields #58

Closed
arteteco opened this issue Dec 8, 2020 · 4 comments
Closed

Hide empty fields #58

arteteco opened this issue Dec 8, 2020 · 4 comments

Comments

@arteteco
Copy link

arteteco commented Dec 8, 2020

Hello everyone,
well, as I wrote, especially for the fields displayed under the user bio would be nice to be able to hide the empty ones

Thanks

@clarkwinkelmann
Copy link
Member

I'm not sure I understand what you're asking.

By default fields are visible in the user's Masquerade tab.

When "show in bio" is enabled, the field is ALSO shown on the user card.

I don't think there is currently any logic to show/hide fields that have been filled or not.

@arteteco
Copy link
Author

arteteco commented Dec 8, 2020

I'm asking to add the feature to hide empty fields, they look especially bad under the bio

Sorry if that part gave you some confusion in understanding the issue, actually it wasn't necessary!

@rafaucau
Copy link
Contributor

rafaucau commented Apr 10, 2021

@clarkwinkelmann It looks bad on a user's profile when someone browses their profile and sees a bunch of blank fields.
image
And if none of the fields are completed, a placeholder should appear.

If displaying blank fields is not intended in this extension then I can do a PR.

@clarkwinkelmann
Copy link
Member

No choice has been made on how to handle this issue so far.

I think my preferred solution would be to apply a className to the fields so that forum owners can customize how empty fields should look like visually, by either adding "Empty" text in pseudo-elements, or hiding the field completely.

If we start adding options to customize the look, I fear we won't know where to stop. If we add an option for this, there will be requests for other customization, and where should we stop. Likewise it would be nice to be able to customize vertical vs horizontal layout for labels+value, but I feel like it might be too much to have that as an option and would be better for custom CSS.

The UI is pretty poor by default, so I wouldn't be against a new default design (CSS, but might also require changes to markup) to give it a more engaging look.

In any case I don't think we should force hiding the fields as some people will want to show empty fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants