Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored headers not darkened #48

Closed
Eumobong opened this issue Aug 17, 2021 · 1 comment
Closed

Colored headers not darkened #48

Eumobong opened this issue Aug 17, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@Eumobong
Copy link

Feature Request

Is your feature request related to a problem? Please describe.

If colored header is enabled in appearance tab of Admin, the colored header is retain even in dark mode for all users.

Describe the solution you'd like

If the admistrator enables colored headers in Admin, the colored headers should be darkened when someone visits the forum frontend and enables dark mode.

Describe alternatives you've considered

Nil

@Eumobong Eumobong added the enhancement New feature or request label Aug 17, 2021
@clarkwinkelmann
Copy link
Member

I think that behavior comes from Flarum itself. All this extension does is switching Flarum's dark mode on and off.

We could add an option to define a value for "Colored header" setting depending on selected dark mode, but I think it's a bit too much complexity to add to this extension.

The other option if for you to define your own custom dark mode CSS that overrides the header color. There are some examples on the forum on how to add custom CSS that only applies to dark mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants