Skip to content
This repository has been archived by the owner on Jun 8, 2024. It is now read-only.

Vector images broken with plugin active #62

Closed
DanMan opened this issue Feb 20, 2020 · 2 comments
Closed

Vector images broken with plugin active #62

DanMan opened this issue Feb 20, 2020 · 2 comments

Comments

@DanMan
Copy link

DanMan commented Feb 20, 2020

This is a follow up to #59, so all the preconditions are the same.

We are using a SVG image for the logo. Right now the plugin tries to convert those images, too, which fails and leads to a broken image in the browser. They don't seem to try the SVG among the sources, if the WebP image fails to load.

The plugin should just leave vector images alone. It doesn't make sense to try to convert them anyway.

shyim added a commit that referenced this issue Feb 22, 2020
@shyim
Copy link
Member

shyim commented Feb 22, 2020

Can you test the attachment commit?

@DanMan
Copy link
Author

DanMan commented Feb 24, 2020

Yup, logo shows up again. Thanks.

It lists the same SVG in 3 <source> elements, which is silly, but that might just be Shopware itself doing that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants