Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UnboundInput #117

Open
jbinto opened this issue May 13, 2016 · 0 comments
Open

Remove UnboundInput #117

jbinto opened this issue May 13, 2016 · 0 comments

Comments

@jbinto
Copy link
Contributor

jbinto commented May 13, 2016

There's no reason we couldn't just make boundToForm a flag/prop on <Frig.Input />, which defaults to true.

Going forward anything that reduces the nesting/hierarchy of these components will be a good thing.

Background: <UnboundInput/> was needed so we could create themed components whose inputs didn't directly bind to the form, e.g. TimePickerPopup which has hours/minutes/amPm as separate inputs (so-called "sub inputs") that together represent a single field. There's no technical reason these couldn't just be plain <input> tags, but we took this approach so we could reuse the themed <FriggingBootstrap.Input> tags and keep consistent styling (/prefix/suffix/label/etc) even for unbound inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant