Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐳 small Dockerfile improvment and updated docker image usage #109

Merged
merged 1 commit into from Jul 5, 2019
Merged

🐳 small Dockerfile improvment and updated docker image usage #109

merged 1 commit into from Jul 5, 2019

Conversation

bgauduch
Copy link
Contributor

@bgauduch bgauduch commented Jul 5, 2019 •
edited

Fix #106

  • after some experimentation, mutli-stage build is definitely not an option with Node.js
  • fixed the workdir (/app) where gitmoji-changelog expect the code to be inside the container
  • updated docker image usage according to the modifications

frinyvonnick
frinyvonnick approved these changes Jul 5, 2019
View reviewed changes
Copy link
Owner

@frinyvonnick frinyvonnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work @bgauduch 👏

@frinyvonnick frinyvonnick merged commit 55e24c2 into frinyvonnick:master Jul 5, 2019
@bgauduch bgauduch deleted the improve-dockerfile branch July 7, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frinyvonnick frinyvonnick frinyvonnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCKER] improve Dockerfile
2 participants
@bgauduch @frinyvonnick