Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added contributors section in README.md #10 #11

Merged
merged 7 commits into from
Oct 7, 2019
Merged

added contributors section in README.md #10 #11

merged 7 commits into from
Oct 7, 2019

Conversation

keremh
Copy link
Contributor

@keremh keremh commented Oct 6, 2019 •
edited by frinyvonnick
Loading

Fix #10

@frinyvonnick
Copy link
Owner

Nice job @keremh 👏, could you add yourself too ?

@frinyvonnick frinyvonnick mentioned this pull request Oct 7, 2019
Closed
@keremh
Copy link
Contributor Author

keremh commented Oct 7, 2019

Thank you @frinyvonnick , of course i will add my information too. ☺️

@frinyvonnick
Copy link
Owner

In this pull request ?

@keremh
Copy link
Contributor Author

keremh commented Oct 7, 2019

Can i add in another pull request?

@frinyvonnick
Copy link
Owner

Sure ! I'll merge this one as soon as possible 👍

frinyvonnick
frinyvonnick reviewed Oct 7, 2019
View reviewed changes
README.md Outdated
@@ -1,4 +1,9 @@
# react-simple-infinite-loading
[![All Contributors](https://img.shields.io/badge/all_contributors-4-orange.svg?style=flat-square)](#contributors-)
[![All Contributors](https://img.shields.io/badge/all_contributors-1-orange.svg?style=flat-square)](#contributors-)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 5 badges could you keep only the first one ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i did it. Can you review code again?

frinyvonnick
frinyvonnick approved these changes Oct 7, 2019
View reviewed changes
Copy link
Owner

@frinyvonnick frinyvonnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @keremh 👏

@frinyvonnick frinyvonnick merged commit 2446fa2 into frinyvonnick:master Oct 7, 2019
@frinyvonnick
Copy link
Owner

@all-contributors please add @keremh for code

@allcontributors allcontributors bot mentioned this pull request Oct 10, 2019
Merged
@allcontributors
Copy link
Contributor

@frinyvonnick

I've put up a pull request to add @keremh! 🎉

@keremh
Copy link
Contributor Author

keremh commented Oct 10, 2019

vaoov this is awesome! 😃

@frinyvonnick
Copy link
Owner

I just added the Github App for all contributors 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frinyvonnick frinyvonnick frinyvonnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add contributors section in README.md
2 participants
@keremh @frinyvonnick