Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks on non-Windows systems without unzip package installed #6

Open
st-sloth opened this issue May 17, 2018 · 3 comments
Open

Breaks on non-Windows systems without unzip package installed #6

st-sloth opened this issue May 17, 2018 · 3 comments
Labels

Comments

@st-sloth
Copy link

Code in this project relies on the notion that if the system is not Windows, then it has CLI command unzip available. However some systems, like Manjaro Linux, don't come with unzip already installed. So cross-unzip just fails with spawn unzip ENOENT.

@fritx
Copy link
Owner

fritx commented May 17, 2018

@st-sloth my bad..

We could probably add more supports, like https://github.com/uiureo/node-screencapture/pull/7/files

@st-sloth
Copy link
Author

Dunno, I don't think depending on external tools will ever be safe anyway. https://www.npmjs.com/package/extract-zip seem to manage with just JS.

@fritx
Copy link
Owner

fritx commented May 18, 2018

@st-sloth yeah that would have both pros and cons.

I had been using tools implemented in pure JS before, but there would be problems like performance, so this library would be an alternative from them.

@fritx fritx added the other-os label Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants