Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up fritz Docker builds w.r.t. configuration #384

Open
stefanv opened this issue Jan 20, 2022 · 1 comment
Open

Clean up fritz Docker builds w.r.t. configuration #384

stefanv opened this issue Jan 20, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@stefanv
Copy link
Contributor

stefanv commented Jan 20, 2022

  1. baselayer/config.yaml.defaults -> skyportal/config.yaml.defaults -> fritz.yaml (we can assume fritz is an end product, does not need customizable defaults)
  2. Document that sections of config can be removed by specifying empty keys
  3. Store only secrets and differential configs in deployment script, rest lives in fritz; this should also reduce chances of messing up the webpack build / template filling in the SOPS config
  4. Remove route matching verification; quite possibly, user does not want that
@stefanv stefanv added the bug Something isn't working label Jan 20, 2022
@stefanv stefanv self-assigned this Jan 20, 2022
@guynir42
Copy link
Collaborator

I think that given the trouble we've seen in recent deployments, this is worth pushing on...

@guynir42 guynir42 self-assigned this Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants