Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kowalski as a submodules? #544

Open
Theodlz opened this issue Apr 14, 2024 · 7 comments
Open

Remove Kowalski as a submodules? #544

Theodlz opened this issue Apr 14, 2024 · 7 comments
Assignees
Labels
infrastructure Infrastructure issues question Further information is requested

Comments

@Theodlz
Copy link
Collaborator

Theodlz commented Apr 14, 2024

We don't deploy Kowalski alongside SkyPortal, and probably never will for good reasons (both systems, based on their hardware requirements, really belong on 2 - or more - different machines).

I'm wondering if it wouldn't make sense to remove Kowalski as a submodule here, from the config, and from the launcher commands. This would make the repo a little bit more maintainable, and limit confusion for contributors.

But also, I think that without Kowalski, Fritz can really be a solid example of what a system that needs to add features on top of vanilla SkyPortal should look like.

@Theodlz Theodlz added enhancement New feature or request infrastructure Infrastructure issues question Further information is requested and removed enhancement New feature or request labels Apr 14, 2024
@Theodlz Theodlz self-assigned this Apr 14, 2024
@Theodlz
Copy link
Collaborator Author

Theodlz commented Apr 14, 2024

@mcoughlin @profjsb @stefanv any thoughts? Maybe something to discuss at the Fritz weekly meeting

@Theodlz
Copy link
Collaborator Author

Theodlz commented Apr 14, 2024

  • obviously, since we haven't been deploying Kowalski with Fritz, it's also incredibly outdated (both the version pinned, config, ...)

@mcoughlin
Copy link
Contributor

@Theodlz completely agreed.

@stefanv
Copy link
Contributor

stefanv commented Apr 15, 2024

It would be good to have a way to do integration testing, if that isn't yet set up on either side.

@Theodlz
Copy link
Collaborator Author

Theodlz commented Jun 1, 2024

@stefanv ah yes definitely. I think that can still happen on git. I'm thinking about pushing kowalski docker images to dockerhub soon, so not too hard to have it run here and pass it the SkyPortal token as an env variable (and vice versa).

@Theodlz
Copy link
Collaborator Author

Theodlz commented Jun 1, 2024

And again this is just an idea. Documenting the existing code a bit mode and cleaning it up might be enough to separate the Fritz and Kowalski stuff enough that someone else can pretty much fork Fritz and modify it into their own skyportal custom app.

@Theodlz
Copy link
Collaborator Author

Theodlz commented Jun 1, 2024

And first, I want to fix the existing integration testing with Kowalski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure issues question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants