Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript types for the addon components and helpers #62

Open
Panman82 opened this issue May 31, 2018 · 3 comments
Open

Add TypeScript types for the addon components and helpers #62

Panman82 opened this issue May 31, 2018 · 3 comments
Milestone

Comments

@Panman82
Copy link
Contributor

Panman82 commented May 31, 2018

Apparently there is a types file that can be added to help with TypeScript support. Probably worth adding since the ember community is moving that direction.

typed-ember/ember-cli-typescript#48

@Panman82 Panman82 added this to the 3.0 milestone May 31, 2018
@Panman82 Panman82 modified the milestones: 3.first, 3.next Jan 28, 2021
@Panman82
Copy link
Contributor Author

Panman82 commented Nov 7, 2022

Just to add here, there is an open issue on the main editor repo (upstream from this Ember addon) requesting that TypeScript definitions be added: froala/wysiwyg-editor#2369

@Panman82
Copy link
Contributor Author

Once this addon moves to embroider (addon v2) format, the actual components/helpers/etc. will move to "native" TypeScript files with all the types needed.

@Panman82 Panman82 modified the milestones: 4.next, 5.first Apr 11, 2023
@Panman82
Copy link
Contributor Author

Just to note, there is apparently upstream types available now, but I haven't looked into them yet: froala/wysiwyg-editor#2369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant