Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolbarSticky not functioning #4612

Closed
jrhess3 opened this issue Apr 4, 2023 · 12 comments
Closed

toolbarSticky not functioning #4612

jrhess3 opened this issue Apr 4, 2023 · 12 comments

Comments

@jrhess3
Copy link

jrhess3 commented Apr 4, 2023

Expected behavior.

The tool bar is no longer sticky on pages using the latest version of the froala editor.

Actual behavior.

The tool bar sticks to the top of the page and is no longer visible. Changing the sticky offset doesn't help

Steps to reproduce the problem.

Try it here: https://www.sfponline.org/PrincipalsNewsletterfroala3.asp

Editor version.

version 4.0.18

Browser.

CHROME and Edge

@Zombaya
Copy link

Zombaya commented May 8, 2023

I can confirm this is happening with us too. Rolled back to 4.0.17 where it still works.

@MarcoWil
Copy link

Also happening for us. When can we expect the fix?

@my2interid
Copy link

my2interid commented May 21, 2023

V4.019 also doesn't work

@herumtreiber
Copy link

Same here. We would need a quick fix as our customers are heavily complaining about this.

@malikov917
Copy link

Can confirm the same behavior. No workaround really helped.

@barryross
Copy link

I can confirm that the "stickyToolbar" option in the config appears to have no effect in v4.1.1

@DavidEichmann
Copy link

DavidEichmann commented Sep 21, 2023

I can confirm this doesn't work on v4.1.2 either jsfiddle. We've rolled back to v4.0.17 in production for now. Please fix!

@Zombaya
Copy link

Zombaya commented Sep 21, 2023

@DavidEichmann, as a heads-up, 4.0.17 does have a security issue which was fixed in 4.1.2, see:

I have an open support-ticket as a paying user since this is blocking us from updating to a secure version, but no news there either.

@DavidEichmann
Copy link

@Zombaya Thanks for the insight. That's an unfortunate vulnerability. Let's hope it gets resolved soon 🤞 .

@Zombaya
Copy link

Zombaya commented Sep 28, 2023

We're in contact with support and the issue has been raised with the development team, so things should start to get moving.

We found out though that having a bootstrap 3 modal (or a div with the class modal attached) seems to be triggering the issue.

See https://jsfiddle.net/ag7uvk09/ for an example.

We we're able to mitigate by replacing the modal with a sweetalert-message-popup.

@DavidEichmann
Copy link

@Zombaya In your jsfiddle and in my own usecase I was able to fix the issue simply by adding the following css (with the correct <toolbarStickyOffset>):

.fr-toolbar.fr-top.fr-sticky-on {
   top: <toolbarStickyOffset>px !important;
}

Of course, you won't be able to set the toolbarStickyOffset dynamically with this workaround. https://jsfiddle.net/davideichmann/unb0egxz/

@ilyaskarim
Copy link

This issue has been fixed in V4.1.4: https://froala.com/wysiwyg-editor/changelog/#4.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants