Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update buy_reasons.py #4

Closed
wants to merge 1 commit into from
Closed

Update buy_reasons.py #4

wants to merge 1 commit into from

Conversation

rokups
Copy link

@rokups rokups commented Jan 10, 2022

Multiple tweaks:

  • clean up use of --no-parallel
  • add --timeframe parameter
  • get data format from config instead of a parameter
  • get pairlist from trades dataframe if pairlist is empty

@rokups
Update buy_reasons.py
0b3812f 
Multiple tweaks:
* clean up use of --no-parallel
* add --timeframe parameter
* get data format from config instead of a parameter
* get pairlist from trades dataframe if pairlist is empty
froggleston
froggleston requested changes Jan 11, 2022
View reviewed changes
Copy link
Owner

@froggleston froggleston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only thing is the description for the --timeframe option is still the text from data_format.

@froggleston
Copy link
Owner

I think I've addressed these points (finally) with the latest update. Could you take a look and see if it matches what you expected from your suggestions?

@rokups rokups closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froggleston froggleston froggleston requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rokups @froggleston