Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRA 3.3.0 #6

Open
DB-Alex opened this issue Dec 6, 2019 · 4 comments
Open

CRA 3.3.0 #6

DB-Alex opened this issue Dec 6, 2019 · 4 comments

Comments

@DB-Alex
Copy link

DB-Alex commented Dec 6, 2019

Hi @jamesknelson ,

When do you expect to bump CURA to 3.3.0?

https://github.com/facebook/create-react-app/releases/tag/v3.3.0

@jamesknelson
Copy link
Collaborator

I plan on having a look this weekend, but not sure if I'll get it finished. The thing about 3.3.0 is that it adds template support, and CURA is basically a custom template, so it's a much much bigger change than the previous release.

I think what needs to happen is that the create-universal-react-app script itself can be dropped, and the whole thing can be set up as two new CRA templates (SSR JS and SSR TS). These templates can then replace react-scripts with universal-react-scripts.

If you'd like to take a look, I'd certainly be happy to accept a PR ;)

@DB-Alex
Copy link
Author

DB-Alex commented Dec 6, 2019

Maybe in time I can help you out with PRs of this kind, but for know I still need to learn a lot :)

Excited about the 3.3.0 release though ;)

@gut4
Copy link

gut4 commented Feb 6, 2020

Any updates on this?

@jamesknelson
Copy link
Collaborator

I took a look at it and found that it's going to be a little unwieldy, as instead of just specifying a scripts-version, you'll now need to specify a matching template.

For now, I've created this issue on CRA to try and help resolve this: facebook/create-react-app#8335. If there's no response soon though, I may just implement this the ugly way where you need to specify a separate template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants