Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Fix Typescript definitions #158

Merged
merged 1 commit into from
May 3, 2019
Merged

Fix Typescript definitions #158

merged 1 commit into from
May 3, 2019

Conversation

stby4
Copy link
Contributor

@stby4 stby4 commented Dec 11, 2018

The lightbox accepts ReactNode elements for imageTitle and imageCaption, as is documented in https://github.com/frontend-collective/react-image-lightbox#options

The current index.d.ts however only allows strings for these attributes. This pull request adds React.ReactNode as possible types.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 106

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.613%
Totals Coverage Status
Change from base Build 105: 0.0%
Covered Lines: 249
Relevant Lines: 555
💛 - Coveralls

@stby4
Copy link
Contributor Author

stby4 commented Dec 13, 2018

Fixes #159 - Types of property 'imageCaption' are incompatible

@mmarkelov mmarkelov mentioned this pull request Jan 4, 2019
Closed
@wuweiweiwu wuweiweiwu merged commit f1858a3 into frontend-collective:master May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wuweiweiwu wuweiweiwu wuweiweiwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stby4 @coveralls @wuweiweiwu