Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

fix for getOrigin issue within iFrames #136 #175

Merged
merged 2 commits into from
Jun 19, 2019
Merged

fix for getOrigin issue within iFrames #136 #175

merged 2 commits into from
Jun 19, 2019

Conversation

zlyfenek
Copy link
Contributor

@zlyfenek zlyfenek commented May 22, 2019 •
edited by wuweiweiwu
Loading

closes: #136
Return self if there is no referrer.

@coveralls
Copy link

coveralls commented May 22, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 119

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 44.839%
Totals Coverage Status
Change from base Build 117: 0.2%
Covered Lines: 255
Relevant Lines: 556
💛 - Coveralls

mmarkelov
mmarkelov reviewed May 23, 2019
View reviewed changes
src/util.js Outdated Show resolved Hide resolved
@wuweiweiwu wuweiweiwu self-assigned this Jun 19, 2019
wuweiweiwu
wuweiweiwu approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@wuweiweiwu wuweiweiwu merged commit f290cb3 into frontend-collective:master Jun 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmarkelov mmarkelov mmarkelov left review comments

@wuweiweiwu wuweiweiwu wuweiweiwu approved these changes

Assignees

@wuweiweiwu wuweiweiwu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getOrigin issue within iFrames
4 participants
@zlyfenek @coveralls @mmarkelov @wuweiweiwu