Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Tab Focus moves in the background #79

Closed
zee0786 opened this issue Oct 13, 2017 · 6 comments
Closed

Tab Focus moves in the background #79

zee0786 opened this issue Oct 13, 2017 · 6 comments

Comments

@zee0786
Copy link

zee0786 commented Oct 13, 2017

Tab Focus moves out of the lightbox after the close icon instead of rotating within the lightbox. I have fixed this code on my local machine but unable to push my branch due to authorization. Please help me

@fritz-c
Copy link
Member

fritz-c commented Oct 13, 2017

If you fork the repository and push your changes to a branch there, you can submit a pull request. I’m curious to see how you fixed this.

@zee0786
Copy link
Author

zee0786 commented Oct 13, 2017

Thanks. I have raised a pull request. Kindly review it

@fritz-c
Copy link
Member

fritz-c commented Oct 15, 2017

Actually, this seems to be a react-modal issue. They have a WIP pull request here:
reactjs/react-modal#521
I will wait on that for the fix. Thank you for the time you put into submitting your pull request for this library's sake.

@diasbruno
Copy link

Hi @zee0786 @fritz-c, it seems that we need to improve the tabbing mechanism on react-modal. Hopefully I'll try to finish this PR today.

@zee0786
Copy link
Author

zee0786 commented Oct 30, 2017

No Problem @diasbruno , I am using forked repo of the same

@fritz-c
Copy link
Member

fritz-c commented Dec 17, 2017

It's been fixed in react-modal now.

@fritz-c fritz-c closed this as completed Dec 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants