You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Google AMP framework doesn't need the custom data- attributes added by React, so instead of using renderToString, the @frontity/amp package needs to make Frontity use renderToStaticMarkup.
This can be done with a beforeSSR function. It'll be necessary to create a separate server.js file because we don't want to add react-dom/server to the client bundle.
This issue wasn't closed automatically after merging the linked Pull Request because we merged it in a branch different than dev, so I'm closing this manually.
This is part of the AMP feature. For full context please check out the final Implementation proposal.
The Google AMP framework doesn't need the custom
data-
attributes added by React, so instead of usingrenderToString
, the@frontity/amp
package needs to make Frontity userenderToStaticMarkup
.This can be done with a
beforeSSR
function. It'll be necessary to create a separateserver.js
file because we don't want to addreact-dom/server
to the client bundle.It needs the
render
function to be exposed inlibraries.frontity
.The text was updated successfully, but these errors were encountered: