Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidive No longer muting. #548

Closed
Andycodesforyou opened this issue Apr 2, 2024 · 6 comments
Closed

Hidive No longer muting. #548

Andycodesforyou opened this issue Apr 2, 2024 · 6 comments
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@Andycodesforyou
Copy link

Andycodesforyou commented Apr 2, 2024

Bug Description

Hello Hidive on multiple devices no longer mutes filters words but the filtering in the captions still work (words are still blotted out). Hidive recently changed their site and updated/changed their video player so I would hazard a guess that this has something to do with it.

Steps To Reproduce

  1. Go to Advance profanity filter options
  2. Click on Audio --> mute audio on supported video sites
  3. Go to Hidive, play a video
  4. Audio not muting on Hidive videos

Expected behavior

Audio muting of videos playing

Devices tested

Macbook pro (2016, Monterey) on Chrome Browser.
Samsung Tablet (Android) on Kiwi browser
Blackview phone (Android) on Kiwi browser.

Settings tested

On the Black view phone tested all the various mute settings.
For Macbook and Samsung only tested standard settings but can test the other settings if needed (assuming it is the same as phone).

Both Youtube's and Crunchyroll's muting works on these other devices so it seems to be specifically Hidive.

@Andycodesforyou Andycodesforyou added the Bug Something isn't working label Apr 2, 2024
@richardfrost
Copy link
Collaborator

Hi @Andycodesforyou,

Thanks for reporting the issue! It looks like they have updated/changed their website quite a bit, which is preventing the filter from working. Could you please give this config a try and see if it works for you? If it doesn't work, please send me a specific video or two where it isn't working so I can get it fixed.

{
  "www.hidive.com": [
    {
      "className": "ds-text-track__wrapper-container",
      "displaySelector": "div.ds-text-track",
      "mode": "element",
      "subtitleSelector": "span.ds-text-track__text",
      "tagName": "DIV"
    }
  ]
}

To use this config, paste it into the Custom Sites area (Options page > Audio tab) and click the blue "SAVE" button underneath it.

@richardfrost richardfrost self-assigned this Apr 5, 2024
@richardfrost richardfrost added this to the Audio milestone Apr 5, 2024
@Andycodesforyou
Copy link
Author

Okay I will do that. Sorry for late replay.

@Andycodesforyou
Copy link
Author

Tested this on Chrome. It works. Will test on the other devices and get back to you @richardfrost

@Andycodesforyou
Copy link
Author

Tested on both Android phone and Samsung tablet in Kiwi browser.

The config file works. @richardfrost .

@richardfrost
Copy link
Collaborator

Thanks @Andycodesforyou for testing it out and getting back to me. I'll add that new config to the next version of the Extension.

@richardfrost
Copy link
Collaborator

This has been included in version 3.5.0 of the extension. For best results, make sure to remove any custom config used for testing like this once it has been included in the official update so you can automatically get future updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants