Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter only applied after page loaded #7

Closed
GoogleCodeExporter opened this issue May 28, 2015 · 1 comment
Closed

Filter only applied after page loaded #7

GoogleCodeExporter opened this issue May 28, 2015 · 1 comment
Labels
Research Needs some investigation

Comments

@GoogleCodeExporter
Copy link

Issue submitted by Martin on Chrome Extension Gallery page:
Hi Mark, the problem with this extension is that it loads the page and only 
then replaces the words. There is a "beforeload" event out now which you can 
use to prevent these bad words from loading at all. I STRONGLY suggest that you 
use it. AdBlock is using it too. It's much better if you don't even load the 
bad word rather than load it and then hide it...


Original issue reported on code.google.com by markyd13 on 2 Aug 2010 at 8:08

@richardfrost
Copy link
Collaborator

richardfrost commented Jun 14, 2015

Not sure that this is the right way to go, but here is an example of the beforeload event.

https://stackoverflow.com/questions/11386246/addeventlistenerbeforeload-missing-events

document.addEventListener( 'beforeload', function( event ) {
    event.preventDefault();
}, true );

Occasionally I do get a page that loads slower and I can catch a glimpse of unfiltered words, but it seems to be quite brief to me. I will wait to hear more feedback on this.

@richardfrost richardfrost added Research Needs some investigation Feedback and removed Bug Something isn't working labels Jun 14, 2015
richardfrost pushed a commit that referenced this issue Jul 3, 2023
https://web.dev/optimize-cls/#images-without-dimensions
![](/attachments/c191a8f8-0495-4283-a1a5-b5bae29c4f4a)

fixes https://codeberg.org/FrostCo/AdvancedProfanityFilter/issues/1

Reviewed-on: https://codeberg.org/FrostCo/AdvancedProfanityFilter/pulls/7
Co-authored-by: HexagonCDN <hexagoncdn@noreply.codeberg.org>
Co-committed-by: HexagonCDN <hexagoncdn@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Research Needs some investigation
Projects
None yet
Development

No branches or pull requests

2 participants