Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with new Faster Initial Filtering #84

Closed
Mohfath opened this issue Jul 11, 2018 · 6 comments
Closed

Problems with new Faster Initial Filtering #84

Mohfath opened this issue Jul 11, 2018 · 6 comments
Labels
Invalid This doesn't seem right

Comments

@Mohfath
Copy link

Mohfath commented Jul 11, 2018

Thanks for the great project.

I would suggest making the "Faster Initial Filtering" feature, as an option.
Since the site I am using, worked fine with last version but by moving to this new Version, all the words are plainly visible and number of filtered words are always zero.

I presume it is a matter of texts loading with javascript waaay after your extension's run.

@richardfrost
Copy link
Collaborator

Thanks for letting me know, and I'm glad you like the project.

I was afraid that something like this would happen, and unfortunately it is not possible to make the change an option. My testers had trouble with Reddit which we were able to work around, would you mind sharing which site has the issue? Ultimately I may have to revert that change all together.

@tonyram57
Copy link

tonyram57 commented Jul 13, 2018

Ultimately I may have to revert that change all together.

Please don't. I am finding the script more reliable than it was before. What Richardfrost said what site is giving you issues. Sure it is not static images made to look like text as no add on can block profanities in images.

@richardfrost
Copy link
Collaborator

richardfrost commented Jul 15, 2018

I will definitely try to solve the problem through other means, as I think the faster initial filtering offers a lot of benefits. I am pretty confident I can work around the issue, so @Mohfath, please let me know what site is causing the problem so I can take a look. The more of these edge cases we can get fixed, the more stable and universal the filter should get! 😄 Thanks again for your support!

@richardfrost
Copy link
Collaborator

I am working on a new "comprehensive" setting, which can be turned on for specific domains. It will allow the filter to be more aggressive/thorough than normal, and will be able to potentially block more words. It will be opt-in for a domain though, because it can also cause more slowdowns and potentially even break a page. Hopefully it will be useful for particularly difficult pages, but not enabled elsewhere.

@richardfrost
Copy link
Collaborator

@Mohfath I have published the "Advanced Mode", which can be enabled on a per-domain basis (Options -> Domains- > Advanced). The new version has other improvements as well, so please let me know if you are still having issues with a particular site. Otherwise in a few days I'll go ahead and close this.

@richardfrost
Copy link
Collaborator

Since there hasn't been any activity on this I'm going to close it. If its still an issue, please try the advanced domain option, and let me know how that goes.

@richardfrost richardfrost added the Invalid This doesn't seem right label May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants