Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update type annotations #298

Merged
merged 5 commits into from Mar 13, 2021
Merged

update type annotations #298

merged 5 commits into from Mar 13, 2021

Conversation

danieleades
Copy link
Contributor

  • replaced a few type comments with type annotations

wanted to check this was of interest before i got too deep into this

@frostming
Copy link
Collaborator

frostming commented Mar 12, 2021 •
edited

Glad to see this piece of work is taken and started. It will be even better if a step can be added to Lint CI that invokes mypy in order to see the effect of the improvement.

@frostming frostming linked an issue Mar 12, 2021 that may be closed by this pull request
Typing #261
Closed
6 tasks
@danieleades
Copy link
Contributor Author

Glad to see this piece of work is taken and started. It will be even better if a step can be added to Lint CI that invokes mypy in order to see the effect of the improvement.

Cool, I'll keep going.
I'd like to add mypy linting too, that's my eventual goal. but there's a way to go before that!

@danieleades
Copy link
Contributor Author

that's the rest of the type comments replaced with annotations.

mypy is currently returning >500 errors. Will probably start chipping away at those in separate pull requests, and keep this one focused on replacing the type comments only.

@danieleades danieleades changed the title [WIP] update type annotations update type annotations Mar 12, 2021
@danieleades danieleades marked this pull request as ready for review March 12, 2021 10:11
@frostming
Copy link
Collaborator

I'd like to add mypy linting too, that's my eventual goal. but there's a way to go before that!

No hurry, just a reminder though.

Will probably start chipping away at those in separate pull requests, and keep this one focused on replacing the type comments only.

That is okay, will start reviewing later

@frostming frostming self-requested a review March 12, 2021 11:05
This was referenced Mar 13, 2021
Closed
Merged
frostming
frostming requested changes Mar 13, 2021
View reviewed changes
Copy link
Collaborator

@frostming frostming left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would you mind adding a news entry news/298.misc.md describing what you did in this PR?

@danieleades
Copy link
Contributor Author

LGTM! Would you mind adding a news entry news/298.misc.md describing what you did in this PR?

sure. Is that what you were after?

(i've not used towncrier before)

@frostming frostming merged commit 2f09774 into pdm-project:master Mar 13, 2021
@frostming
Copy link
Collaborator

No more to do, that is it

@danieleades danieleades deleted the refactor/type-annotations branch March 13, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostming frostming frostming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing
2 participants
@danieleades @frostming