Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about LDR->HDR using SRiTMO #22

Closed
pureexe opened this issue Nov 1, 2023 · 2 comments
Closed

Question about LDR->HDR using SRiTMO #22

pureexe opened this issue Nov 1, 2023 · 2 comments

Comments

@pureexe
Copy link

pureexe commented Nov 1, 2023

I would like to thank you for creating such a great work.

I am currently working on panorama prediction, and my pipeline currently produces LDR 360 panoramas. I would like to feed the output of my pipeline to the SRiTMO module to get HDR panoramas.

However, when I feed the LDR images from the Laval Indoor Dataset (which is what the paper was trained on) to the SRiTMO module, the output values reach into the millions, while the actual HDR images are not that high. Is this normal? Do you expect this to happen?

This behavior causes the RMSE of the inverse tone-mapping between SRiTMO and the ground truth to reach a range of millions, compared to less than one as reported in the paper (Table 3).

Or I may misunderstand the table. Could you please explain the exact method you used to calculate the RMSE?

You can find the LDR and HDR images from the Laval Indoor Dataset that I used to test here:

https://vistec-my.sharepoint.com/:f:/g/personal/pakkapon_p_s19_vistec_ac_th/EoiQ7nRJZkFDiLQnKIDLVvYBjRF4xKU2shCnfDI1g14zew?e=N1NQtG

Best regards,
Pakkapon Phongthawee

@FrozenBurning
Copy link
Owner

Thanks for your interest in our work! The way we calculate RMSE is tailored with scale-invariant preprocessing. Given a paired HDR ground truth and HDR prediction, we load them using this function:

def load_raw_hdr(path):

Then, we apply tonemapping on HDR ground truth using:

def reinhard_tmo(hdr, gamma=1.5, intensity = 0., light_adapt = 0., color_adapt = 0.):

Both of the predicted envmap and ground truth envmap are calibrated (

LDR_I = np.mean(LDR, axis=2)
) according to this tonemapped LDR to remove luminance scale. Then the MSE are calculated.

@FrozenBurning
Copy link
Owner

Close due to inactivity. Feel free to reopen for further questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants