Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Tooltip for SpellFlyoutButton(?)s #12

Closed
hobulian opened this issue Jan 5, 2022 · 9 comments
Closed

[Feature request] Tooltip for SpellFlyoutButton(?)s #12

hobulian opened this issue Jan 5, 2022 · 9 comments
Labels
1_enhancement New feature or request 2_to develop Development can begin 3_solved Issue is fixed

Comments

@hobulian
Copy link

hobulian commented Jan 5, 2022

Dunno what is that button frame

SpellFlyoutButton? when i clicked that button pops up multi spell buttons.

Icons didn't show up to that frames.

https://imgur.com/a/FecpLPD

@frozn
Copy link
Owner

frozn commented Jan 5, 2022

Do you have activated "ItemRef->Smart Icon Appearance"? If yes, it's correct that they didn't pop up, because an icon is already shown (on the button).

@hobulian
Copy link
Author

hobulian commented Jan 6, 2022

Do you have activated "ItemRef->Smart Icon Appearance"? If yes, it's correct that they didn't pop up, because an icon is already shown (on the button).

I didn't activated Smart icon feature. Only that button that aggregate other spells(by form of SpellFlyoutButton) doesn't have tooltip icon i think. It's same to SL M+ dungeon portals.
https://imgur.com/a/lS9Gxap

@frozn
Copy link
Owner

frozn commented Jan 7, 2022

I added border color and infos for flyouts and pet actions (config options under "ItemRef"). That was pretty nasty to implement... 😩

Spells in macros on action bar should also work now.

I committed these changes to the main-branch. I already had a look at it, but could you possibly also take a look in whether the issues are fixed?

I can't check the part with the SL M+ dungeon portals yet. I'm on here.

I didn't built a new release yet... I want to merge several bugfixes/enhancements, so that not too many announcements have to be made. The releases currently have to be installed manually, which is otherwise too time-consuming for the people.

@hobulian
Copy link
Author

hobulian commented Jan 7, 2022

I added border color and infos for flyouts and pet actions (config options under "ItemRef"). That was pretty nasty to implement... 😩

Spells in macros on action bar should also work now.

I committed these changes to the main-branch. I already had a look at it, but could you possibly also take a look in whether the issues are fixed?

I can't check the part with the SL M+ dungeon portals yet. I'm on here.

I didn't built a new release yet... I want to merge several bugfixes/enhancements, so that not too many announcements have to be made. The releases currently have to be installed manually, which is otherwise too time-consuming for the people.

I've checked your workout . It's quite great work. Except if you put flyoutbutton into actionbar, seems not working. It works quite fine when in spell book!

@frozn
Copy link
Owner

frozn commented Jan 8, 2022

Strange... my flyout buttons with mage portals or warlock daemons are working fine (with Bartender4 enabled for my action bars and without).

@hobulian
Copy link
Author

hobulian commented Jan 8, 2022

Strange... my flyout buttons with mage portals or warlock daemons are working fine (with Bartender4 enabled for my action bars and without).

Oh it's working now maybe I mis implemented fixed codes. My bad.

@frozn
Copy link
Owner

frozn commented Jan 9, 2022

In the near future, I probably won't be able to do a +20 mythic dungeon to get an M+ dungeon portal. Do you eventually have on of them unlocked yet? If yes, do the flyouts of the M+ dungeon portals work with the current changes?

@hobulian
Copy link
Author

hobulian commented Jan 9, 2022

In the near future, I probably won't be able to do a +20 mythic dungeon to get an M+ dungeon portal. Do you eventually have on of them unlocked yet? If yes, do the flyouts of the M+ dungeon portals work with the current changes?

I unlocked them and it worked :)

@frozn
Copy link
Owner

frozn commented Jan 9, 2022

That are great news! Then this issue should be solved.

@frozn frozn closed this as completed Jan 9, 2022
@hobulian hobulian changed the title Tooltip for SpellFlyoutButton(?)s [Feature request] Tooltip for SpellFlyoutButton(?)s Jan 28, 2022
@frozn frozn added 1_enhancement New feature or request 2_to develop Development can begin labels Feb 20, 2022
@frozn frozn added the 3_solved Issue is fixed label Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1_enhancement New feature or request 2_to develop Development can begin 3_solved Issue is fixed
Projects
None yet
Development

No branches or pull requests

2 participants