New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
削除についてはjournal領域変更が先、データ領域変更が後 #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yuezato Please explain why this change was required. |
I've found that the reason why this change was required was discussed on gitter. |
後でGitterを遡るのは辛いので念のため書いておきます。 最大の理由は、 Lines 371 to 386 in b908df6
ジャーナル領域への削除通知を後回しにしてしまうと、ジャーナル領域変更直前にcannylsがクラッシュした場合、復旧後にはcannylsのindex情報復元の都合上、削除前の状態に巻き戻ってしまいます。 何らかの性質を満たすために |
ありがとうございます |
No description provided.