Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to change put_content_timeout dynamically. #39

Closed
shinnya opened this issue Nov 19, 2018 · 3 comments · Fixed by #45
Closed

Allow users to change put_content_timeout dynamically. #39

shinnya opened this issue Nov 19, 2018 · 3 comments · Fixed by #45
Assignees

Comments

@shinnya
Copy link
Contributor

shinnya commented Nov 19, 2018

I would like to allow users to change put_content_timeout.

Background

frugalos automatically adds 60 secs to put_content_timeout specified by a user. It's inconvenient to debug a repair operation because the timeout also affects to a processing delay of Synchronizer.

@shinnya
Copy link
Contributor Author

shinnya commented Nov 19, 2018

related code:

let put_content_timeout = Seconds(if let Deadline::Within(d) = deadline {

let duration = cmp::min(duration, Duration::from_secs(MAX_TIMEOUT_SECONDS));

@shinnya shinnya self-assigned this Nov 19, 2018
@shinnya
Copy link
Contributor Author

shinnya commented Nov 27, 2018

put_content_timeout の 60 固定を修正する方針として、理想的には bucket の作成時に設定できると良さそうですが、コマンドラインオプションで設定できるようにするのがお手軽で悩ましいです。

@shinnya
Copy link
Contributor Author

shinnya commented Nov 29, 2018

IMO, it's convenient to change the configuration without re-creating/modifying a bucket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant