Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

‘link’ handle in readme is misleading #15

Closed
joshuabaker opened this issue Jul 29, 2015 · 9 comments
Closed

‘link’ handle in readme is misleading #15

joshuabaker opened this issue Jul 29, 2015 · 9 comments

Comments

@joshuabaker
Copy link

link is a reserved work so might be worth replacing the documentation.

This tripped me up when using SuperTable, which doesn’t validate handles (verbb/super-table#19).

@seb-thomas
Copy link

@joshuabaker Thanks for this! That was real fookin me up. Would never have thought of that....
👍

@samhibberd
Copy link
Contributor

@joshuabaker What would you suggest? We are planning to use the __toString() method such that {{ entry.yourLinkItField }} will return the link html.

@joshuabaker
Copy link
Author

I was just raising a minor semantical issue that I noticed in the readme, which assigns entry.yourLinkItField to a link variable within the template.

A few people have been tripped up by looking through the readme and using link as a field handle, a reserved word, for LinkIt fields within a SuperTable field.

@samhibberd
Copy link
Contributor

Good call, i've updated the Readme.

@sidneywidmer
Copy link

+1, any updates on this?

@joshuabaker
Copy link
Author

@sidneywidmer: See 6cb36fd, a97223d, and d46f87a

@sidneywidmer
Copy link

shit sorry, posted my comment on the wrong issue :) I was talking about the one with the localization, probably it was a bit too early for me

@samhibberd
Copy link
Contributor

link will be removed in the upcoming update

@samhibberd
Copy link
Contributor

Fixed in the latest release, please make sure you backup and test out pre launch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants