Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize comparison when comparing builds #1817

Closed
frzyc opened this issue Mar 22, 2024 · 0 comments · Fixed by #1828
Closed

Standardize comparison when comparing builds #1817

frzyc opened this issue Mar 22, 2024 · 0 comments · Fixed by #1828
Assignees

Comments

@frzyc
Copy link
Owner

frzyc commented Mar 22, 2024

There is a discrepancy between the current/colored comparison build in terms of "build result" vs "tc interface". We should seek to standardize this:
[current build number] [+/- compare build number]

This should make it so that regardless if you are comparing or not, the "white text" should show the "current build" value

Also, in the codebase, the DataContext are referred to as {data, oldData}, which is not be best naming, I'd recommend refactoring to {data, compareData} to ease this transition.

@frzyc frzyc mentioned this issue Mar 25, 2024
5 tasks
@frzyc frzyc self-assigned this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant