Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Button-like Inputs to TextField in TC tab (main stats) #2046

Closed
frzyc opened this issue Apr 30, 2024 · 2 comments · Fixed by #2153
Closed

Convert Button-like Inputs to TextField in TC tab (main stats) #2046

frzyc opened this issue Apr 30, 2024 · 2 comments · Fixed by #2153
Assignees
@artloren
Labels
good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR

Comments

@frzyc
Copy link
Owner

frzyc commented Apr 30, 2024 •
edited
Loading

image

Convert the inputs here to TextField

Probably replace the background color to border color?
@frzyc frzyc added the good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR label Apr 30, 2024
@artloren
Copy link
Contributor

artloren commented May 14, 2024 •
edited
Loading

I can take a look at this!

@frzyc
Copy link
Owner Author

frzyc commented May 15, 2024

@artloren I've assigned the issue to you, I've also merged in a number specific lazy input: #2128, I would advice using this for standardization.

@artloren artloren mentioned this issue May 19, 2024
Merged
5 tasks
@frzyc frzyc changed the title Convert Button-like Inputs to TextField in TC tab Convert Button-like Inputs to TextField in TC tab (main stats) May 20, 2024
@frzyc frzyc mentioned this issue May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artloren artloren

Labels
good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

convert artifact level button to textfield on theorycraft page artloren/genshin-optimizer-artlor
2 participants
@frzyc @artloren