Add Force parameter to Choco Push #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove duplicate additional arguments - add Force option to ChocoPushParams
- fixed Force description
|
Is this ready? |
|
Not yet. |
matthid
reviewed
Jan 27, 2018
| /// | ||
| /// args |> Choco.CallChoco TimeSpan.FromMinutes 1. | ||
| /// ) | ||
| let CallChoco args timeout = |
There was a problem hiding this comment.
Maybe "Exec" so that it reads Choco.Exec in the code? (currently it will read Choco.CallChoco)
|
I think this is already an improvement we can always fire again with additional PRs :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #1734