Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET SDK 2.1.400, 2.1.401, 2.1.402 #2089

Merged
merged 1 commit into from Sep 22, 2018
Merged

Add .NET SDK 2.1.400, 2.1.401, 2.1.402 #2089

merged 1 commit into from Sep 22, 2018

Conversation

zakaluka
Copy link

Description

3 new .NET SDKs are out, but currently the only way to use them with FAKE is with global.json. This adds supports directly in DotNet.Versions.

TODO

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)
    • Current fields have no additional documentation
  • unit or integration test exists (or short reasoning why it doesn't make sense)
    • Could not find tests for previous SDK versions, not sure it needs testing.
  • [] (if new module) the module has been linked from the "Modules" menu, edit help/templates/template.cshtml, linking to the API-reference is fine.
    • N/A
  • [] (if new module) the module is in the correct namespace
    • N/A
  • [] (if new module) the module is added to Fake.sln (dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)
    • N/A
  • Fake 5 API guideline is honored
    • follows current .NET SDK pattern.

@matthid
Copy link
Member

matthid commented Sep 15, 2018

Hey thanks a lot, I feel like mid-long term we might need a different approach considering the amount of versions... For now your change looks good.

@zakaluka
Copy link
Author

If there was a way to list the contents of https://dotnetcli.azureedge.net/dotnet/, that may help dynamically generate the available versions.

@zakaluka
Copy link
Author

Another option may be to parse the .NET SDK pages (https://www.microsoft.com/net/download/dotnet-core/2.2, https://www.microsoft.com/net/download/dotnet-core/2.1, etc.), find <h3> elements with an id starting with sdk-, and then creating entries for each entry found. FSharp.Data's HTML parser could be used to do that.

@zakaluka
Copy link
Author

Ok, I think I finally got it - I believe that https://github.com/dotnet/core/blob/master/release-notes/releases.json contains the available releases.

version-sdk-display and version-sdk (if the former is unavailable) contain the version numbers that seems to be downloadable. Using those to create the Versions may make the most sense.

I'll try it out in a separate branch and you can review it to see if the approach makes sense.

@matthid
Copy link
Member

matthid commented Sep 15, 2018

@zakaluka Yes indeed, either something like that or just "pinning" major and minor version and adding the "patch" version as "int" parameter? Anyway this definitely looks good and I'm merging it on the next release.

@matthid matthid merged commit 7d32cbe into fsprojects:release/next Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants