test and fix the gitlab reporter #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthid
requested changes
Mar 7, 2020
| @@ -172,32 +172,33 @@ module GitLab = | |||
| member x.LogSectionName = | |||
| sprintf "%s_%s" (x.Type.Trim()) (x.Name.Trim()) | |||
|
|
|||
| type Writer = bool -> System.ConsoleColor -> bool -> string -> unit | |||
There was a problem hiding this comment.
Should those aliases be internal?
| @@ -214,9 +215,10 @@ module GitLab = | |||
| write false color true (sprintf "Build Number: %s" number) | |||
| | TraceData.TestStatus (test, status) -> | |||
| write false color true (sprintf "Test '%s' status: %A" test status) | |||
|
|
|||
| let currentTicks () = | |||
There was a problem hiding this comment.
Suggested change
| let currentTicks () = | |
| let internal currentTicks () = |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Puts the gitlab trace writer under tests and establishes that it does in fact write the log messages expected by the documentation on gitlab.
The problem before was the console escape sequences were not being escaped in the format strings, so .Net was applying the for us.