Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dotCover helper for cover/merge/report #318

Merged
merged 1 commit into from Feb 2, 2014

Conversation

@jamescrowley
Copy link
Contributor

commented Feb 2, 2014

Any thoughts on this? I don't like having to create specific DotCover helpers for Nunit/MSpec but couldn't come up with a nicer way right now without more fundamental changes... but at least re-used the Nunit/MSpec buildargs functions.

Seq.find isNotNullOrEmpty [workingDir; environVar("teamcity.build.workingDir"); "."]
|> Path.GetFullPath

let buildParamsAndExecute parameters buildArguments toolPath workingDir =

This comment has been minimized.

Copy link
@jamescrowley

jamescrowley Feb 2, 2014

Author Contributor

Both getWorkingDir and buildParamsAndExecute could potentially be extracted out of here. Or perhaps made explicitly private? I stole getWorkingDir from elsewhere but it was tied to specific parameter types

forki added a commit that referenced this pull request Feb 2, 2014
Merge pull request #318 from jamescrowley/develop
Added dotCover helper for cover/merge/report

@forki forki merged commit 306add7 into fsharp:develop Feb 2, 2014

1 check passed

default The Travis CI build passed
Details
forki added a commit that referenced this pull request Feb 2, 2014
@forki

This comment has been minimized.

Copy link
Member

commented Feb 2, 2014

I merged it and removed the autoopen in order to get it into the 2.8 release.

Please send a new Pull Request with other changes if you want.

Thanks for your good work. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.