Added dotCover helper for cover/merge/report #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Seq.find isNotNullOrEmpty [workingDir; environVar("teamcity.build.workingDir"); "."] | ||
| |> Path.GetFullPath | ||
|
|
||
| let buildParamsAndExecute parameters buildArguments toolPath workingDir = |
There was a problem hiding this comment.
Both getWorkingDir and buildParamsAndExecute could potentially be extracted out of here. Or perhaps made explicitly private? I stole getWorkingDir from elsewhere but it was tied to specific parameter types
|
Please add traceStartTask/traceEndTask see |
forki
added a commit
that referenced
this pull request
Feb 2, 2014
Added dotCover helper for cover/merge/report
forki
added a commit
that referenced
this pull request
Feb 2, 2014
|
I merged it and removed the autoopen in order to get it into the 2.8 release. Please send a new Pull Request with other changes if you want. Thanks for your good work. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any thoughts on this? I don't like having to create specific DotCover helpers for Nunit/MSpec but couldn't come up with a nicer way right now without more fundamental changes... but at least re-used the Nunit/MSpec buildargs functions.