Introduced thread-affine CultureInfo cache #1033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caches CultureInfo per Thread in order to improve DateTime parsing when parsing with specific Culture
The idea for this optimization started from this StackOverflow question: https://stackoverflow.com/questions/42469637/
Performance numbers:
Parsing 100000 dates
Using cached CultureInfo object...
took 114 ms
Using updated TextRuntime.GetCulture...
took 144 ms
Using fresh CultureInfo object (same technique as old TextRuntime.GetCulture)...
took 52556 ms