Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TPSDK and paket targets #1250

Merged
merged 5 commits into from Mar 21, 2019
Merged

update TPSDK and paket targets #1250

merged 5 commits into from Mar 21, 2019

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Mar 20, 2019

This updates the TPSDK to contain the fix for #1249

thanks
don

@dsyme
Copy link
Contributor Author

dsyme commented Mar 20, 2019

Error in CI:

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> Fake.Core.BuildFailedException: Target 'Build' failed. ---> System.AggregateException: One or more errors occurred. ---> System.IO.FileNotFoundException: Could not find file 'C:\projects\fsharp-data\FSharp.Data.DesignTime'.
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize)
   at System.Xml.XmlDownloadManager.GetStream(Uri uri, ICredentials credentials, IWebProxy proxy, RequestCachePolicy cachePolicy)
   at System.Xml.XmlUrlResolver.GetEntity(Uri absoluteUri, String role, Type ofObjectToReturn)
   at System.Xml.XmlTextReaderImpl.FinishInitUriString()
   at System.Xml.XmlTextReaderImpl..ctor(String uriStr, XmlReaderSettings settings, XmlParserContext context, XmlResolver uriResolver)

@dsyme
Copy link
Contributor Author

dsyme commented Mar 20, 2019

OK, well, there seem to be problems building the repo. On my local machine I get

       SourceLinkCreate:
         git rev-parse --show-toplevel
         'git' is not recognized as an internal or external command,
         operable program or batch file.
     1>C:\Users\dsyme\.nuget\packages\sourcelink.create.commandline\2.8.0\build\SourceLink.Create.CommandLine.targets(21,5): error MSB3073: The command "git rev-parse --show-toplevel" exited with code 9009. [C:\GitHub\dsyme\FSharp.Data\src\FSharp.Data.DesignTime\FSharp.Data.DesignTime.fsproj]

@baronfel
Copy link
Contributor

Ugh, we need to update the version of sourcelink used to the non-clitool version to sidestep this class of errors: https://github.com/dotnet/sourcelink

@dsyme
Copy link
Contributor Author

dsyme commented Mar 20, 2019

@baronfel It looks like the build with the MSBuild toolchain has been busted for a while, even before 3.0.0 release

I just added a commit to remove the use of the MSBuild toolchain altogether, to see how it goes, and see if we can get CI green

If we get it green we can consider bringing back the MSBuild toolchain - though as long as we're testing on .NET Core and .NET Framework it may be enough (obviously it would be good to test on Mono too, but maybe the dotnet chain is doing that anyway)

@dsyme
Copy link
Contributor Author

dsyme commented Mar 20, 2019

Hmmm

  • appveyor is green and a nuget has been produced.
  • On windows tests have been run on both netcoreapp2.0 and net461

So that's a good sign.

@dsyme
Copy link
Contributor Author

dsyme commented Mar 21, 2019

CI seems much healthier now

@ovatsus @baronfel If it's green in the morning I'll tag this as 3.0.1 and we can release a new nuget - this is quite an important fix for #1249

@dsyme
Copy link
Contributor Author

dsyme commented Mar 21, 2019

ok, green it is. And Mono testing is included on travis:

Test run for /home/travis/build/fsharp/FSharp.Data/tests/FSharp.Data.DesignTime.Tests/bin/Release/netcoreapp2.0/FSharp.Data.DesignTime.Tests.dll(.NETCoreApp,Version=v2.0)

e/travis/build/fsharp/FSharp.Data/tests/FSharp.Data.DesignTime.Tests/bin/Release/net461/FSharp.Data.DesignTime.Tests.dll(.NETFramework,Version=v4.6.1)

Will pull this and tag

@dsyme dsyme merged commit 89b0e6a into fsprojects:master Mar 21, 2019
@ovatsus
Copy link

ovatsus commented Mar 21, 2019

@dsyme do you want me to do the 3.01 release today? Or I can give you permission to the nuget package as well so you can do it

@ovatsus
Copy link

ovatsus commented Mar 21, 2019

Released 3.01 and added you as owner of the nuget package

@dsyme
Copy link
Contributor Author

dsyme commented Mar 21, 2019

Released 3.01 and added you as owner of the nuget package

Thank you! Great to have this released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants